Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SESSION-3933: Global setting to metasrv #4049

Merged

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Feb 3, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  • Add setting to metasrv api

This patch not do(TODO in another patch):

  • Read global settings and over-write the local settings

Changelog

  • Improvement

Related Issues

Part of #3933

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/BFz2v37XMtYfLFmEo6yNyYbkgA8C
✅ Preview: Canceled

[Deployment for b0fba26 canceled]

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #4049 (89a09d9) into main (8686115) will decrease coverage by 0%.
The diff coverage is 84%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4049   +/-   ##
=====================================
- Coverage     57%     57%   -1%     
=====================================
  Files        820     823    +3     
  Lines      43432   43511   +79     
=====================================
+ Hits       24800   24844   +44     
- Misses     18632   18667   +35     
Impacted Files Coverage Δ
common/management/src/stage/stage_mgr.rs 94% <0%> (ø)
common/management/src/udf/udf_mgr.rs 88% <0%> (ø)
common/meta/types/src/user_setting.rs 75% <ø> (-25%) ⬇️
...uery/src/sql/statements/statement_show_settings.rs 0% <0%> (ø)
query/src/users/user_setting.rs 0% <0%> (ø)
common/management/src/setting/setting_mgr.rs 96% <96%> (ø)
query/src/interpreters/interpreter_setting.rs 95% <100%> (+11%) ⬆️
query/src/storages/system/settings_table.rs 92% <100%> (+<1%) ⬆️
query/src/users/user_api.rs 80% <100%> (+3%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8686115...89a09d9. Read the comment docs.

@BohuTANG BohuTANG force-pushed the dev-global-settings-3933-patch-4 branch from 5f2f6d7 to 89a09d9 Compare February 4, 2022 07:38
@BohuTANG BohuTANG changed the title SESSION-3933: Write global setting to metasrv SESSION-3933: Global setting to metasrv Feb 4, 2022
@BohuTANG BohuTANG marked this pull request as ready for review February 4, 2022 08:31
@BohuTANG
Copy link
Member Author

BohuTANG commented Feb 5, 2022

There are no major logic changes in this patch, Let's merge and continue.

@BohuTANG BohuTANG merged commit 7f3b25a into datafuselabs:main Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants