Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SESSIONS-3933: Refine the file and field name #4015

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

BohuTANG
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

  • rename query/src/sessions/{context.rs => query_ctx.rs} (97%)
  • rename query/src/sessions/{context_shared.rs => query_ctx_shared.rs} (99%)
  • rename query/src/sessions/{session_status.rs => session_ctx.rs} (97%)
  • rename query/src/sessions/{sessions.rs => session_mgr.rs} (97%)
  • delete mode 100644 query/src/sessions/sessions_info.rs, move to sessions_mgr.rs
  • Rename MutableStatus to SessionContext

Changelog

  • Improvement

Related Issues

Patch-1 of #3933

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/Ef3CBz2s9gWouSTZMeWKC5ADxxfy
✅ Preview: Canceled

[Deployment for dbd85f0 canceled]

@codecov-commenter
Copy link

Codecov Report

Merging #4015 (dbd85f0) into main (845b811) will decrease coverage by 0%.
The diff coverage is 77%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #4015    +/-   ##
======================================
- Coverage     57%     57%    -1%     
======================================
  Files        806     811     +5     
  Lines      43170   43310   +140     
======================================
+ Hits       24703   24719    +16     
- Misses     18467   18591   +124     
Impacted Files Coverage Δ
common/meta/sled-store/src/sled_serde.rs 100% <ø> (ø)
query/src/interpreters/interpreter_copy.rs 0% <0%> (ø)
common/dal2/src/services/s3.rs 22% <10%> (-47%) ⬇️
common/dal2/src/ops/header.rs 75% <75%> (ø)
common/dal2/src/ops/stat.rs 77% <75%> (ø)
common/dal2/src/readers/stream.rs 75% <75%> (ø)
common/dal2/src/ops/delete.rs 87% <85%> (ø)
common/dal2/src/readers/seekable.rs 97% <97%> (ø)
common/dal2/src/operator.rs 100% <100%> (ø)
common/dal2/src/ops/read.rs 94% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed07108...dbd85f0. Read the comment docs.

@databend-bot
Copy link
Member

Wait for another reviewer approval

@zhang2014 zhang2014 merged commit ffd5026 into datafuselabs:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants