chore: make vacuum temp files batch #15430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
BohuTANG
force-pushed
the
dev-vacuum-temp-file-paral-2
branch
from
add79ba
to
3eea325
Compare
zhang2014
approved these changes
May 8, 2024
zhang2014
reviewed
May 8, 2024
| remove_temp_files_name.push(de.name().to_string()); | ||
| } | ||
|
|
||
| // If the batch size is reached, remove the files in batch. | ||
| if expired_files.len() >= BATCH_SIZE { |
There was a problem hiding this comment.
maybe operator.remove_via is better?
|
Move to #15434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Batch process the
VACUUM TEMPORARY FILESoperation. For every 10,000 files, perform a removal in parallel batches.Tests
Type of change
This change is