Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use NonEmptyString to create Settings #14875

Merged
merged 2 commits into from
Mar 7, 2024
Merged

refactor: use NonEmptyString to create Settings #14875

merged 2 commits into from
Mar 7, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Mar 7, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: use NonEmptyString to create Settings

Changelog

  • Improvement

Related Issues

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 7, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review March 7, 2024 08:39
@drmingdrmer
Copy link
Member Author

@zhang2014
@BohuTANG
In some cases, Settings is created with empty string tenant. I replaced such case with creating with "dummy" tenant.

@drmingdrmer drmingdrmer merged commit 27d0e2f into datafuselabs:main Mar 7, 2024
70 checks passed
@drmingdrmer drmingdrmer deleted the 33-settings branch March 7, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drmingdrmer @zhang2014