Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support right-related join spilling #14853

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat: support right-related join spilling #14853

merged 4 commits into from
Mar 6, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Mar 6, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft March 6, 2024 07:09
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 6, 2024
@xudong963 xudong963 added the ci-cloud Build docker image for cloud test label Mar 6, 2024
@xudong963 xudong963 marked this pull request as ready for review March 6, 2024 08:08
@xudong963 xudong963 mentioned this pull request Mar 6, 2024
Open
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Docker Image for PR

  • tag: pr-14853-10b3fdf

note: this image tag is only available for internal use,
please check the internal doc for more details.

Dousir9
Dousir9 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! the failed ci test is not related to this PR.

@xudong963 xudong963 enabled auto-merge March 6, 2024 09:14
@xudong963 xudong963 added this pull request to the merge queue Mar 6, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 6, 2024
@BohuTANG BohuTANG merged commit 5dbaf9b into datafuselabs:main Mar 6, 2024
71 checks passed
@xudong963 xudong963 deleted the spill_right_join branch March 6, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xudong963 @Dousir9 @BohuTANG