Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): introduce arrow-udf-js #14799

Merged
merged 35 commits into from
Mar 4, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Support javascript udf runtime

python udf is todo (hard to resolve the pyenv in build script)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 29, 2024
@sundy-li sundy-li changed the title feat(query): introduce arrow-udf feat(query): introduce arrow-udf-js Mar 4, 2024
@sundy-li sundy-li marked this pull request as ready for review March 4, 2024 04:48
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 64 files at r1, 40 of 59 files at r2.
Reviewable status: 49 of 75 files reviewed, 2 unresolved discussions (waiting on @b41sh, @sundy-li, and @xudong963)

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 64 files at r1, 59 of 59 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @b41sh and @sundy-li)

@BohuTANG BohuTANG merged commit 6777c17 into datafuselabs:main Mar 4, 2024
72 of 73 checks passed
@BohuTANG
Copy link
Member

BohuTANG commented Mar 4, 2024

Weird.
This PR some struct should respect to #14822, but this PR is merge first, then merged 14822, the CI is failed:
https://github.com/datafuselabs/databend/actions/runs/8138095404/job/22238061462#step:4:2561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support javascript udf
4 participants