chore(query): modify new_agg_hashtable payload transmission method on singleton and support new_agg_hashtable on cluster #14798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
|
Please provide a summary of this PR, highlighting its key objectives :) |
Docker Image for PR
|
sundy-li
reviewed
Mar 4, 2024
src/query/service/src/pipelines/processors/transforms/aggregator/transform_partition_bucket.rs
Show resolved
Hide resolved
sundy-li
reviewed
Mar 4, 2024
src/query/sql/src/executor/physical_plans/physical_aggregate_partial.rs
Outdated
Show resolved
Hide resolved
Freejww
changed the title
sundy-li
approved these changes
Mar 5, 2024
11 tasks
11 tasks
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
… singleton and support new_agg_hashtable on cluster (datafuselabs#14798)
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Jun 18, 2024
… singleton and support new_agg_hashtable on cluster (datafuselabs#14798) * refactor new_agg_hashtable * test * test * fmt * test * test * test * format explain --------- Co-authored-by: jw <freejw@gmail.com> (cherry picked from commit f04c367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In the previous PR feat(query): agg-hashtable-singleton #14524, we implemented a new_agg_hashtable on singleton. In the partial phase, we sent the entire
PartitionedPayload. While this approach is correct for singletons, it may cause scatter skew if used in the same manner on a cluster. To ensure compatibility with the cluster, we refactored the payload transmission method for new_agg_hashtable in the standalone version. Now, we send each individualPayloadseparately.support new_agg_hashtable on cluster, to be enabled using:
set enable_experimental_aggregate_hashtable = 1;Tests
Type of change
This change is