Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor join spilling settings #14781

Merged
merged 2 commits into from
Feb 28, 2024
Merged

refactor: refactor join spilling settings #14781

merged 2 commits into from
Feb 28, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Feb 28, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 28, 2024
@xudong963 xudong963 added the ci-cloud Build docker image for cloud test label Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14781-9d78c72

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963 xudong963 added this pull request to the merge queue Feb 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2024
@xudong963
refactor: refactor join spilling settings (#14781)
eb8857c 
* refactor: refactor join spilling settings

* fix lint
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 28, 2024
@BohuTANG BohuTANG merged commit 4def8bb into datafuselabs:main Feb 28, 2024
70 checks passed
@xudong963 xudong963 deleted the refactor branch February 28, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

join_spilling_threshold to ratio
3 participants
@xudong963 @zhang2014 @BohuTANG