Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor hash join spill probe side #14743

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Feb 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Make spilled-related logic as independent as possible.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 26, 2024
@xudong963 xudong963 marked this pull request as draft February 26, 2024 12:07
@xudong963 xudong963 marked this pull request as ready for review February 26, 2024 13:55
@xudong963 xudong963 added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@xudong963 xudong963 added this pull request to the merge queue Feb 27, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 27, 2024
@BohuTANG BohuTANG merged commit 1a8b2e4 into datafuselabs:main Feb 27, 2024
71 checks passed
@xudong963 xudong963 deleted the refactor_spill branch February 27, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants