Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't return empty credentail if load failed #14734

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Current reqsign cloud return empty credentail if load failed, this PR fixed it.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title fix(storage/s3): Don't return empty credentail if load failed fix: Don't return empty credentail if load failed Feb 26, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 26, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo added this pull request to the merge queue Feb 26, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 26, 2024
@BohuTANG BohuTANG merged commit 24063c0 into datafuselabs:main Feb 26, 2024
68 checks passed
@Xuanwo Xuanwo deleted the fix-cred-not-loaded branch May 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants