Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): refactor runtime part 4 #14728

Merged
merged 21 commits into from
Feb 26, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Feb 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): refactor runtime

extract stat buffer
extract mem stat
add more unit test

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 25, 2024
@xudong963 xudong963 self-requested a review February 26, 2024 02:29
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Feb 26, 2024
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 26, 2024
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 26, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-14728-d7c0c62

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

Docker Image for PR

  • tag: pr-14728-2868479

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

Docker Image for PR

  • tag: pr-14728-7f7ca88

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhang2014 zhang2014 marked this pull request as ready for review February 26, 2024 06:19
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 26, 2024
@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 26, 2024
@BohuTANG
Copy link
Member

image Not sure this is a degradation or not?

@zhang2014
Copy link
Member Author

Not sure this is a degradation or not?

no cluster related modifications, let's run it again.

Copy link
Contributor

Docker Image for PR

  • tag: pr-14728-1dc2207

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

Docker Image for PR

  • tag: pr-14728-4756d98

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit 57297a5 into datafuselabs:main Feb 26, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants