Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add div0 divnull method #14693

Merged
merged 8 commits into from
Feb 20, 2024
Merged

feat: add div0 divnull method #14693

merged 8 commits into from
Feb 20, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 20, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

add div0 divnull method

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 20, 2024
@sundy-li sundy-li mentioned this pull request Feb 20, 2024
Closed
@sundy-li
Copy link
Member Author

@soyeric128 need doc

@andylokandy andylokandy added this pull request to the merge queue Feb 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 20, 2024
@BohuTANG BohuTANG merged commit eef8ebe into datafuselabs:main Feb 20, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@b41sh b41sh Awaiting requested review from b41sh

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add function div0 and div0null
4 participants
@sundy-li @andylokandy @BohuTANG @ankit-pn