refactor: add UdfError::Exist #14691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
TCeason
reviewed
Feb 20, 2024
BohuTANG
reviewed
Feb 20, 2024
- refactor: get_udf() returns None, not ErrorCode. So that the caller is able to distinguish a backend meta-service error and a `NotFound` error more easily. - refactor: drop_udf(): return None if not dropped. This way to distinguish service level error and logic error. - Split UdfError into two error: `UdfError` defines only logic error, `UdfApiError` defines errors occurred in the service level or dependent components, such as `Tenant`. These two errors do not overlap.
Refine error handling for `UdfMgr`. Avoid using `ErrorCode`, but instead, use structured error `UdfError` or `UdfApiError` if possible. Convert to `ErrorCode` as late as possible.
By using `NonEmptyStr` and `NonEmptyString` to store a tenant, `UserApiProvider` guarantees the tenant str is valid. Other changes: - An error should not contain any **tenant** info in its `to_string()` result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add UdfError::Exist
Refine error handling for
UdfMgr.Avoid using
ErrorCode, but instead, use structured errorUdfErrororUdfApiErrorif possible.Convert to
ErrorCodeas late as possible.refactor: rename get_udfs to list_udf
refactor: seperate logic error and service error for UDF API
refactor: get_udf() returns None, not ErrorCode.
So that the caller is able to distinguish a backend meta-service error
and a
NotFounderror more easily.refactor: drop_udf(): return None if not dropped. This way to
distinguish service level error and logic error.
Split UdfError into two error:
UdfErrordefines only logic error,UdfApiErrordefines errors occurred in the service level ordependent components, such as
Tenant. These two errors do notoverlap.
Changelog
Related Issues
This change is