-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename: bricks -> databricks #393
Conversation
cmd/root/logger.go
Outdated
envBricksLogFile = "BRICKS_LOG_FILE" | ||
envBricksLogLevel = "BRICKS_LOG_LEVEL" | ||
envBricksLogFormat = "BRICKS_LOG_FORMAT" | ||
envDatabricksCliLogFile = "DATABRICKS_CLI_LOG_FILE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pietern or do we want DATABRICKS_LOG_FILE
?
cmd/root/io.go
Outdated
@@ -8,14 +8,14 @@ import ( | |||
"github.com/spf13/cobra" | |||
) | |||
|
|||
const envBricksOutputFormat = "BRICKS_OUTPUT_FORMAT" | |||
const envDatabricksCliOutputFormat = "DATABRICKS_CLI_OUTPUT_FORMAT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be DATABRICKS_OUTPUT_FORMAT
cmd/root/logger.go
Outdated
envBricksLogFormat = "BRICKS_LOG_FORMAT" | ||
envDatabricksCliLogFile = "DATABRICKS_CLI_LOG_FILE" | ||
envDatabricksCliLogLevel = "DATABRICKS_CLI_LOG_LEVEL" | ||
envDataricksCliLogFormat = "DATABRICKS_CLI_LOG_FORMAT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, we should drop the _CLI
@pietern I'd leave the |
@@ -12,7 +12,7 @@ type Config struct { | |||
AzureTenantId string `json:"azure_tenant_id,omitempty"` | |||
AzureUseMsi bool `json:"azure_use_msi,omitempty"` | |||
AzureWorkspaceResourceId string `json:"azure_workspace_resource_id,omitempty"` | |||
BricksCliPath string `json:"bricks_cli_path,omitempty"` | |||
DatabricksCliPath string `json:"databricks_cli_path,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a Terraform provider bump as well -- can be done and verified async.
cmd/root/io.go
Outdated
@@ -8,14 +8,14 @@ import ( | |||
"github.com/spf13/cobra" | |||
) | |||
|
|||
const envBricksOutputFormat = "BRICKS_OUTPUT_FORMAT" | |||
const envDatabricksCliOutputFormat = "DATABRICKS_OUTPUT_FORMAT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the symbol as well.
## Changes CLI: * Sync: Gracefully handle broken notebook files ([#398](#398)). * Add version flag to print version and exit ([#394](#394)). * Pass temporary directory environment variables to subprocesses ([#395](#395)). * Rename environment variables `BRICKS_` -> `DATABRICKS_` ([#393](#393)). * Update to Go SDK v0.9.0 ([#396](#396)).
Changes
related to databricks/databricks-vscode#721
Rename env vars
BRICKS_CLI_PATH
->DATABRICKS_CLI_PATH
BRICKS_OUTPUT_FORMAT
->DATABRICKS_OUTPUT_FORMAT
BRICKS_LOG_FILE
->DATABRICKS_LOG_FILE
BRICKS_LOG_LEVEL
->DATABRICKS_LOG_LEVEL
BRICKS_LOG_FORMAT
->DATABRICKS_LOG_FORMAT
BRICKS_PROGRESS_FORMAT
->DATABRICKS_CLI_PROGRESS_FORMAT
BRICKS_UPSTREAM
->DATABRICKS_CLI_UPSTREAM
BRICKS_UPSTREAM_VERSION
->DATABRICKS_CLI_UPSTREAM_VERSION