Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional keyword argument in take signature #644

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix optional keyword argument in take signature #644

merged 2 commits into from
Jul 10, 2023

Commits on Jul 5, 2023

  1. Fix optional kwarg in function signature 

    This commit fixes the function signature for `take`. Namely, when
an input array is one-dimensional, the `axis` kwarg is optional;
when the array has more than one dimension, the `axis` kwarg is
required. Unfortunately, the type signature cannot encode this
duality, and we must rely on the specification text to clarify
that the `axis` kwarg is required for arrays having ranks greater
than unity.

Ref: data-apis/array-api-compat#34
    @kgryte
    kgryte committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ae408cc View commit details
    Browse the repository at this point in the history

  2. Fix imports

    @kgryte
    kgryte committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4d93cdc View commit details
    Browse the repository at this point in the history