Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to isinf #530

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add complex number support to isinf #530

merged 1 commit into from
Dec 5, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 28, 2022

This PR

  • adds complex number support to isinf by documenting special cases. Namely, as long as either a real or imaginary component is positive or negative infinity, the result should be True, including if the other component is NaN. This follows C (one infinity model), Python, Julia, and NumPy.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.

Reference

>>> z
(inf+nanj)
>>> cmath.isinf(z)
True
>>> import numpy as np
>>> z
(inf+nanj)
>>> np.isinf(np.array([z]))
array([ True])
julia> z
Inf + NaN*im

julia> isinf(z)
true

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 28, 2022
@kgryte kgryte added this to the v2022 milestone Nov 28, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems consistent with existing practice, and I don't think there were any remaining concerns with that behavior. In it goes, thanks @kgryte

@rgommers rgommers merged commit f81cc32 into main Dec 5, 2022
@rgommers rgommers deleted the cmplx-isinf branch December 5, 2022 16:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants