Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify expected values in ones and ones_like when dtype is a complex number data type #438

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Clarify expected values in ones and ones_like when dtype is a complex number data type #438

merged 1 commit into from
Jun 6, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented May 23, 2022 •
edited by rgommers
Loading

This PR

  • adds a note to both ones and ones_like concerning expected output values when dtype is either complex64 or complex128. Namely, only real components are ones. Imaginary components are zero for all elements.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels May 23, 2022
@kgryte kgryte added this to the v2022 milestone May 23, 2022
@kgryte kgryte mentioned this pull request May 23, 2022
Closed
rgommers
rgommers approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte
Copy link
Contributor Author

kgryte commented Jun 6, 2022

As this PR has received approval and the changes are straightforward, will go ahead and merge...

@kgryte kgryte merged commit 9a0960a into main Jun 6, 2022
@kgryte kgryte deleted the cmplx-ones branch June 6, 2022 19:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers