Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for tables.remove method #611

Conversation

sinchana-kumbale
Copy link
Contributor

@sinchana-kumbale sinchana-kumbale commented Feb 27, 2024

  • Wrote test for feature
  • Added changes to CHANGELOG.md

Changes proposed:
Added a test for tables.remove in line with issue #476
The test ensures method returns None and modifies no rows when called with an empty row list

@coveralls
Copy link

coveralls commented Mar 3, 2024

Coverage Status

coverage: 94.976% (+0.04%) from 94.935%
when pulling 12b2b12 on sinchana-kumbale:sinchana/test-coverage-remove-table-row
into 9a200e0 on data-8:master.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just one comment.

tests/test_tables.py Outdated Show resolved Hide resolved
@davidwagner davidwagner dismissed adnanhemani’s stale review March 14, 2024 07:14

Spacing issue has been addressed

@davidwagner davidwagner merged commit 0c82a19 into data-8:master Mar 14, 2024
2 checks passed
@sinchana-kumbale sinchana-kumbale deleted the sinchana/test-coverage-remove-table-row branch March 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants