-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite test_reconnect to use subproc to kill scheduler reliably #6967
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 35m 55s ⏱️ - 7m 18s For more details on these failures, see this check. Results for commit e5a6c2d. ± Comparison against base commit c083790. ♻️ This comment has been updated with latest results. |
🟢 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Couple style nits, take them or leave them
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of fixing this!
…k#6967) Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
I noticed that even on a successful run of this test, we get a lot of "AsyncioGroup already closed" etc. errors since we clearly cripple the running scheduler by closing all the internals manually. Particularly the client and worker disconnects can trigger us trying to schedule messages to deal with the loss.
Looking at the test, we can see a lot of CancelledErrors with long tracebacks. I'm wondering if we're simply hitting #6211 and #6847 is not responsible after all but merely changed timing such that we hit this condition more reliably.
Let's see what CI thinks about this theory.