Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wait_for_state() #6581

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jun 15, 2022

Blocks #6579

@crusaderky crusaderky linked an issue Jun 15, 2022 that may be closed by this pull request
@crusaderky crusaderky marked this pull request as ready for review June 15, 2022 14:49
@crusaderky crusaderky self-assigned this Jun 15, 2022
@crusaderky
Copy link
Collaborator Author

Ready for review and merge

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±    0         15 suites  ±0   6h 40m 42s ⏱️ + 14m 21s
  2 872 tests +    1    2 790 ✔️ ±    0       81 💤 +  1  1 ±0 
21 735 runs  +469  20 734 ✔️ +404  1 000 💤 +65  1 ±0 

For more details on these failures, see this check.

Results for commit cecf2c0. ± Comparison against base commit 33c5cb2.

♻️ This comment has been updated with latest results.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Got some merge conflicts unfortunately

@crusaderky crusaderky merged commit ab46f6a into dask:main Jun 16, 2022
@crusaderky crusaderky deleted the WSMR/wait_for_state branch June 16, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yank state machine out of Worker class
2 participants