Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow leaked threads on windows #6152

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Apr 19, 2022

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

Unit Test Results

       16 files  ±0         16 suites  ±0   7h 15m 48s ⏱️ - 7m 57s
  2 745 tests ±0    2 664 ✔️  - 1       80 💤 ±0  1 +1 
21 845 runs  ±0  20 810 ✔️ +1  1 034 💤  - 2  1 +1 

For more details on these failures, see this check.

Results for commit 2835b83. ± Comparison against base commit 8931939.

@graingert graingert marked this pull request as ready for review April 19, 2022 10:31
@mrocklin
Copy link
Member

I'm glad to see this. Merging.

@mrocklin mrocklin merged commit fc5b460 into dask:main Apr 19, 2022
@graingert graingert deleted the clean-threading-windows branch April 19, 2022 11:44
@mrocklin
Copy link
Member

CI failure recorded here: #6153

@mrocklin
Copy link
Member

Fixed in #6155

I don't know what do to with https://github.com/graingert/distributed/runs/6074901185?check_suite_focus=true , although maybe @fjetter does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants