-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure distributed.comm.core.connect can always be cancelled #6064
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,9 +27,9 @@ | |
from hashlib import md5 | ||
from importlib.util import cache_from_source | ||
from time import sleep | ||
from types import ModuleType | ||
from types import CoroutineType, ModuleType | ||
from typing import Any as AnyType | ||
from typing import ClassVar | ||
from typing import ClassVar, TypeVar | ||
|
||
import click | ||
import tblib.pickling_support | ||
|
@@ -1621,3 +1621,27 @@ def is_python_shutting_down() -> bool: | |
from distributed import _python_shutting_down | ||
|
||
return _python_shutting_down | ||
|
||
|
||
T = TypeVar("T") | ||
|
||
|
||
async def ensure_cancellation(coro: CoroutineType[None, None, T]) -> T: | ||
"""Ensure that the wrapped coro will raise a CancelledError even if its | ||
result is already set. | ||
|
||
See https://github.com/python/cpython/issues/86296 | ||
""" | ||
watcher = asyncio.Event() | ||
|
||
task = asyncio.create_task(coro) | ||
task.add_done_callback(lambda _: watcher.set()) | ||
|
||
try: | ||
await watcher.wait() | ||
except asyncio.CancelledError: | ||
task.cancel() | ||
await watcher.wait() | ||
raise | ||
Comment on lines
+1643
to
+1645
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not entirely sure if I need to await the task itself here. There are no warnings cc @graingert |
||
|
||
return task.result() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests do not capture this race condition but the rewrite is much cleaner and covers more ground so I'd like to keep it