-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI job for oldest supported dependencies #461
Conversation
Should the minimum required version of dask by 1.0.0 instead of 0.18.2? #455 (comment) and #458 (comment) |
To start, I just wanted to match the minimum versions specified in |
Several of the test failures here (ref https://circleci.com/gh/dask/dask-ml/3484?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) are related to newer features in our dependencies (e.g. What minimum version numbers for our dependencies do we want to support? As @stsievert pointed out, there has been mention of dask 1.0.0 as a lower bound for dask. @TomAugspurger any thoughts on a minimum version for pandas? |
Dask 1.0 sounds good.
I'm fine with a relatively new version of pandas. 0.23.4 probably makes
sense.
…On Fri, Feb 15, 2019 at 9:44 PM James Bourbeau ***@***.***> wrote:
Several of the test failures here (ref
https://circleci.com/gh/dask/dask-ml/3484?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
are related to newer features in our dependencies (e.g.
dd.DataFrame.to_dask_array was included in the dask 0.19.0 release, the
dtype argument for pandas.get_dummies was included in the pandas 0.23.0
release, etc.)
What minimum version numbers for our dependencies do we want to support?
As @stsievert <https://github.com/stsievert> pointed out
<#461 (comment)>, there
has been mention of dask 1.0.0 as a lower bound for dask. @TomAugspurger
<https://github.com/TomAugspurger> any thoughts on a minimum version for
pandas? setup.py currently has pandas 0.21.0 as the minimum (which was
released in October 2017).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#461 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIu6gjmZ2s-unyPltjDKaUZvkVTITks5vN36kgaJpZM4a-Wp4>
.
|
Hmm apparently the flake8 pulled from conda-forge is checking things in type comments? I'd recommend just removing those for now. |
Unrelated failures should be fixed, if you could merge master and push again. |
I think this should be ready for review now (cc @TomAugspurger). Summary of changes made in this PR:
|
Thanks. |
This PR adds a CircleCI job to run our tests against the oldest supported version of our dependencies. Closes #456.