Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incremental bug with Dask sharedict #455

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix incremental bug with Dask sharedict #455

merged 1 commit into from
Feb 13, 2019

Conversation

jrbourbeau
Copy link
Member

Currently we're passing a dictionary values method to sharedict.merge instead of the actual values themselves. Fixes #454.

TomAugspurger
TomAugspurger approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

#456 for actually testing this on CI.

@jrbourbeau
Copy link
Member Author

@TomAugspurger by supporting sharedict in addition to highlevelgraph, we're trying to support other versions of Dask than the latest release. Do we want to set an official minimum version of Dask? Perhaps 1.0.0?

@jrbourbeau
Copy link
Member Author

You beat me to it!

@TomAugspurger
Copy link
Member

Thanks. #457 for the doc issue.

@TomAugspurger TomAugspurger merged commit 5688504 into dask:master Feb 13, 2019
@jrbourbeau jrbourbeau deleted the fix_partial_fit branch February 13, 2019 18:47
This was referenced Feb 14, 2019
Merged
Merged
@GenevieveBuckley GenevieveBuckley mentioned this pull request Feb 28, 2019
Closed
@TomAugspurger TomAugspurger mentioned this pull request Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrbourbeau @TomAugspurger