fix: Exception null type in listinvoice #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Jul 6, 2022
| @@ -25,7 +25,7 @@ class AppInvoice { | |||
| final String bolt11; | |||
|
|
|||
| /// The quantity of Bitcoin in millisatoshi | |||
| final int amount; | |||
| final String amount; | |||
There was a problem hiding this comment.
this is a tricky update, core lightning in the actual version the millisatishi is a string, but will began a integer, I think the only problem that you are facing is correct, but we need to open a issue to keep track of this core lightning update regarding the millisatoshi fileld.
because it can cause some strange crash!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22