Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining both listFunds and listInvoices to get list of payments #19

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

KAVAN-DESAI
Copy link
Member

No description provided.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, no design error and this is cool, only small comments :)

lib/api/cln/request/list_invoices_request.dart Outdated Show resolved Hide resolved
lib/views/home/home_view.dart Outdated Show resolved Hide resolved
lib/views/home/home_view.dart Outdated Show resolved Hide resolved
lib/views/home/home_view.dart Outdated Show resolved Hide resolved
Comment on lines +117 to +118
Widget _buildSpecificPaymentView(
AsyncSnapshot<List<dynamic>> snapshot, int index) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Widget _buildSpecificPaymentView(
AsyncSnapshot<List<dynamic>> snapshot, int index) {
Widget _buildSpecificPaymentView({required BuildContext contex, required List<dynamic> items, required int idex}) {
return items[index].identifier == "invoice"

This is the convention that we are following on the repo!

@vincenzopalazzo vincenzopalazzo merged commit 3a837e8 into dart-lightning:main Jul 3, 2022
@vincenzopalazzo vincenzopalazzo mentioned this pull request Jul 3, 2022
@KAVAN-DESAI KAVAN-DESAI deleted the listpayments branch July 4, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants