Fetch full developer.log messages

[elliette]

Fixes #2330, flutter/devtools#3222

The CDP consoleAPICalled event args are RemoteObjects with only the objectPreview provided. This objectPreview is what we were previously constructing the RemoteLog from. Since they are only a preview, the log messages are abbreviated.

To get the full log message, we need to fetch the full object using getProperties.

Confirmed that we now see unabbreviated logs in DevTools:

[elliette]

Will update the CHANGELOG once I reset DWDS (it was just released): #2334

[nshahan]

I'm so excited you found the answer to the truncating message! Thank you so much!

Is there an easy way to reproduce the truncating so that we can test it is no longer happening?

And just to document our in person conversation, we can look into the inspect() API as well.

[elliette]

I'm so excited you found the answer to the truncating message! Thank you so much!

Is there an easy way to reproduce the truncating so that we can test it is no longer happening?

And just to document our in person conversation, we can look into the inspect() API as well.

Added a test case, and opened a bug and added a TODO for inspect

[toineheuvelmans]

My webdev version is 3.4.0, which should include this fix, but I still see truncated logs. Am I missing something?

[elliette]

Hi @toineheuvelmans ! Could you file an issue here with steps to reproduce? https://github.com/dart-lang/webdev/issues/new?assignees=&labels=package%3Awebdev&projects=&template=webdev.md

It's possible we aren't able to fetch the full logs here:

webdev/dwds/lib/src/services/chrome_proxy_service.dart

Line 1486 in 2024775

: _fetchAbbreviatedLogParams(logObject);

Thanks!

[toineheuvelmans]

Hi @elliette, here you go, I hope this suffices: #2400