Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter double types to num #78

Merged
merged 1 commit into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

- Fixed a bug where `typedef`s were not declared with the IDL type's
nullability.
- Types that were aliased to `double` are now aliased to `num`. This is to make
it easier for users to pass integer values without going through a cast and to
make migration from `dart:html` easier.

## 0.2.2-beta

Expand Down
24 changes: 12 additions & 12 deletions lib/src/dom/accelerometer.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ class Accelerometer implements Sensor {
}

extension AccelerometerExtension on Accelerometer {
external double? get x;
external double? get y;
external double? get z;
external num? get x;
external num? get y;
external num? get z;
}

@JS()
Expand Down Expand Up @@ -51,19 +51,19 @@ class GravitySensor implements Accelerometer {
@anonymous
class AccelerometerReadingValues implements JSObject {
external factory AccelerometerReadingValues({
required double? x,
required double? y,
required double? z,
required num? x,
required num? y,
required num? z,
});
}

extension AccelerometerReadingValuesExtension on AccelerometerReadingValues {
external set x(double? value);
external double? get x;
external set y(double? value);
external double? get y;
external set z(double? value);
external double? get z;
external set x(num? value);
external num? get x;
external set y(num? value);
external num? get y;
external set z(num? value);
external num? get z;
}

@JS()
Expand Down
8 changes: 4 additions & 4 deletions lib/src/dom/ambient_light.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@ class AmbientLightSensor implements Sensor {
}

extension AmbientLightSensorExtension on AmbientLightSensor {
external double? get illuminance;
external num? get illuminance;
}

@JS()
@staticInterop
@anonymous
class AmbientLightReadingValues implements JSObject {
external factory AmbientLightReadingValues({required double? illuminance});
external factory AmbientLightReadingValues({required num? illuminance});
}

extension AmbientLightReadingValuesExtension on AmbientLightReadingValues {
external set illuminance(double? value);
external double? get illuminance;
external set illuminance(num? value);
external num? get illuminance;
}
6 changes: 3 additions & 3 deletions lib/src/dom/battery_status.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ class BatteryManager implements EventTarget {}

extension BatteryManagerExtension on BatteryManager {
external bool get charging;
external double get chargingTime;
external double get dischargingTime;
external double get level;
external num get chargingTime;
external num get dischargingTime;
external num get level;
external set onchargingchange(EventHandler value);
external EventHandler get onchargingchange;
external set onchargingtimechange(EventHandler value);
Expand Down
6 changes: 3 additions & 3 deletions lib/src/dom/compute_pressure.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ extension PressureRecordExtension on PressureRecord {
@staticInterop
@anonymous
class PressureObserverOptions implements JSObject {
external factory PressureObserverOptions({double sampleRate});
external factory PressureObserverOptions({num sampleRate});
}

extension PressureObserverOptionsExtension on PressureObserverOptions {
external set sampleRate(double value);
external double get sampleRate;
external set sampleRate(num value);
external num get sampleRate;
}
4 changes: 2 additions & 2 deletions lib/src/dom/css_animation_worklet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class WorkletAnimationEffect implements JSObject {}
extension WorkletAnimationEffectExtension on WorkletAnimationEffect {
external EffectTiming getTiming();
external ComputedEffectTiming getComputedTiming();
external set localTime(double? value);
external double? get localTime;
external set localTime(num? value);
external num? get localTime;
}

@JS('WorkletAnimation')
Expand Down
8 changes: 4 additions & 4 deletions lib/src/dom/css_animations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class AnimationEvent implements Event {

extension AnimationEventExtension on AnimationEvent {
external String get animationName;
external double get elapsedTime;
external num get elapsedTime;
external String get pseudoElement;
}

Expand All @@ -28,16 +28,16 @@ extension AnimationEventExtension on AnimationEvent {
class AnimationEventInit implements EventInit {
external factory AnimationEventInit({
String animationName,
double elapsedTime,
num elapsedTime,
String pseudoElement,
});
}

extension AnimationEventInitExtension on AnimationEventInit {
external set animationName(String value);
external String get animationName;
external set elapsedTime(double value);
external double get elapsedTime;
external set elapsedTime(num value);
external num get elapsedTime;
external set pseudoElement(String value);
external String get pseudoElement;
}
Expand Down
6 changes: 3 additions & 3 deletions lib/src/dom/css_font_loading.dart
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ class FontFaceVariationAxis implements JSObject {}
extension FontFaceVariationAxisExtension on FontFaceVariationAxis {
external String get name;
external String get axisTag;
external double get minimumValue;
external double get maximumValue;
external double get defaultValue;
external num get minimumValue;
external num get maximumValue;
external num get defaultValue;
}

@JS('FontFaceVariations')
Expand Down
118 changes: 59 additions & 59 deletions lib/src/dom/css_layout_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ extension LayoutChildExtension on LayoutChild {
class LayoutFragment implements JSObject {}

extension LayoutFragmentExtension on LayoutFragment {
external double get inlineSize;
external double get blockSize;
external set inlineOffset(double value);
external double get inlineOffset;
external set blockOffset(double value);
external double get blockOffset;
external num get inlineSize;
external num get blockSize;
external set inlineOffset(num value);
external num get inlineOffset;
external set blockOffset(num value);
external num get blockOffset;
external JSAny? get data;
external ChildBreakToken? get breakToken;
}
Expand All @@ -74,22 +74,22 @@ extension LayoutFragmentExtension on LayoutFragment {
class IntrinsicSizes implements JSObject {}

extension IntrinsicSizesExtension on IntrinsicSizes {
external double get minContentSize;
external double get maxContentSize;
external num get minContentSize;
external num get maxContentSize;
}

@JS('LayoutConstraints')
@staticInterop
class LayoutConstraints implements JSObject {}

extension LayoutConstraintsExtension on LayoutConstraints {
external double get availableInlineSize;
external double get availableBlockSize;
external double? get fixedInlineSize;
external double? get fixedBlockSize;
external double get percentageInlineSize;
external double get percentageBlockSize;
external double? get blockFragmentationOffset;
external num get availableInlineSize;
external num get availableBlockSize;
external num? get fixedInlineSize;
external num? get fixedBlockSize;
external num get percentageInlineSize;
external num get percentageBlockSize;
external num? get blockFragmentationOffset;
external BlockFragmentationType get blockFragmentationType;
external JSAny? get data;
}
Expand All @@ -99,33 +99,33 @@ extension LayoutConstraintsExtension on LayoutConstraints {
@anonymous
class LayoutConstraintsOptions implements JSObject {
external factory LayoutConstraintsOptions({
double availableInlineSize,
double availableBlockSize,
double fixedInlineSize,
double fixedBlockSize,
double percentageInlineSize,
double percentageBlockSize,
double blockFragmentationOffset,
num availableInlineSize,
num availableBlockSize,
num fixedInlineSize,
num fixedBlockSize,
num percentageInlineSize,
num percentageBlockSize,
num blockFragmentationOffset,
BlockFragmentationType blockFragmentationType,
JSAny? data,
});
}

extension LayoutConstraintsOptionsExtension on LayoutConstraintsOptions {
external set availableInlineSize(double value);
external double get availableInlineSize;
external set availableBlockSize(double value);
external double get availableBlockSize;
external set fixedInlineSize(double value);
external double get fixedInlineSize;
external set fixedBlockSize(double value);
external double get fixedBlockSize;
external set percentageInlineSize(double value);
external double get percentageInlineSize;
external set percentageBlockSize(double value);
external double get percentageBlockSize;
external set blockFragmentationOffset(double value);
external double get blockFragmentationOffset;
external set availableInlineSize(num value);
external num get availableInlineSize;
external set availableBlockSize(num value);
external num get availableBlockSize;
external set fixedInlineSize(num value);
external num get fixedInlineSize;
external set fixedBlockSize(num value);
external num get fixedBlockSize;
external set percentageInlineSize(num value);
external num get percentageInlineSize;
external set percentageBlockSize(num value);
external num get percentageBlockSize;
external set blockFragmentationOffset(num value);
external num get blockFragmentationOffset;
external set blockFragmentationType(BlockFragmentationType value);
external BlockFragmentationType get blockFragmentationType;
external set data(JSAny? value);
Expand Down Expand Up @@ -172,35 +172,35 @@ extension BreakTokenOptionsExtension on BreakTokenOptions {
class LayoutEdges implements JSObject {}

extension LayoutEdgesExtension on LayoutEdges {
external double get inlineStart;
external double get inlineEnd;
external double get blockStart;
external double get blockEnd;
external double get inline;
external double get block;
external num get inlineStart;
external num get inlineEnd;
external num get blockStart;
external num get blockEnd;
external num get inline;
external num get block;
}

@JS()
@staticInterop
@anonymous
class FragmentResultOptions implements JSObject {
external factory FragmentResultOptions({
double inlineSize,
double blockSize,
double autoBlockSize,
num inlineSize,
num blockSize,
num autoBlockSize,
JSArray childFragments,
JSAny? data,
BreakTokenOptions breakToken,
});
}

extension FragmentResultOptionsExtension on FragmentResultOptions {
external set inlineSize(double value);
external double get inlineSize;
external set blockSize(double value);
external double get blockSize;
external set autoBlockSize(double value);
external double get autoBlockSize;
external set inlineSize(num value);
external num get inlineSize;
external set blockSize(num value);
external num get blockSize;
external set autoBlockSize(num value);
external num get autoBlockSize;
external set childFragments(JSArray value);
external JSArray get childFragments;
external set data(JSAny? value);
Expand All @@ -216,23 +216,23 @@ class FragmentResult implements JSObject {
}

extension FragmentResultExtension on FragmentResult {
external double get inlineSize;
external double get blockSize;
external num get inlineSize;
external num get blockSize;
}

@JS()
@staticInterop
@anonymous
class IntrinsicSizesResultOptions implements JSObject {
external factory IntrinsicSizesResultOptions({
double maxContentSize,
double minContentSize,
num maxContentSize,
num minContentSize,
});
}

extension IntrinsicSizesResultOptionsExtension on IntrinsicSizesResultOptions {
external set maxContentSize(double value);
external double get maxContentSize;
external set minContentSize(double value);
external double get minContentSize;
external set maxContentSize(num value);
external num get maxContentSize;
external set minContentSize(num value);
external num get minContentSize;
}
6 changes: 3 additions & 3 deletions lib/src/dom/css_paint_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ extension PaintWorkletGlobalScopeExtension on PaintWorkletGlobalScope {
String name,
VoidFunction paintCtor,
);
external double get devicePixelRatio;
external num get devicePixelRatio;
}

@JS()
Expand Down Expand Up @@ -53,6 +53,6 @@ class PaintRenderingContext2D
class PaintSize implements JSObject {}

extension PaintSizeExtension on PaintSize {
external double get width;
external double get height;
external num get width;
external num get height;
}
8 changes: 4 additions & 4 deletions lib/src/dom/css_transitions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class TransitionEvent implements Event {

extension TransitionEventExtension on TransitionEvent {
external String get propertyName;
external double get elapsedTime;
external num get elapsedTime;
external String get pseudoElement;
}

Expand All @@ -27,16 +27,16 @@ extension TransitionEventExtension on TransitionEvent {
class TransitionEventInit implements EventInit {
external factory TransitionEventInit({
String propertyName,
double elapsedTime,
num elapsedTime,
String pseudoElement,
});
}

extension TransitionEventInitExtension on TransitionEventInit {
external set propertyName(String value);
external String get propertyName;
external set elapsedTime(double value);
external double get elapsedTime;
external set elapsedTime(num value);
external num get elapsedTime;
external set pseudoElement(String value);
external String get pseudoElement;
}
Loading