Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review feedback from globalContext change #69

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Review feedback from globalContext change #69

merged 1 commit into from
Sep 18, 2023

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 18, 2023

And add test

sigmundch
sigmundch approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@sigmundch sigmundch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kevmoo
Copy link
Member Author

kevmoo commented Sep 18, 2023

Landing on red. We can publish once the needed dev release is out!

@kevmoo kevmoo merged commit 5080d04 into main Sep 18, 2023
11 of 13 checks passed
@kevmoo kevmoo deleted the cleanup branch September 18, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmundch sigmundch sigmundch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @sigmundch