-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globalContext rename #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there is an info error that is making the bots unhappy, should we fix that too?
After those, we should bump and publish the package. Not sure if we have set up the auto-publish bot on this repo though.
@@ -53,7 +53,7 @@ Element? querySelector(String selectors) => document.querySelector(selectors); | |||
|
|||
bool isInstanceOfDomType(JSObject? o, String domType) { | |||
if (o == null) return false; | |||
final constructor = globalJSObject[domType.toJS]; | |||
final constructor = globalContext.getProperty(domType.toJS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can do globalContext[domType]
(now []
takes Strings instead of JSStrings to make it easier to write).
@@ -6,7 +6,7 @@ version: 0.1.4-beta | |||
repository: https://github.com/dart-lang/web | |||
|
|||
environment: | |||
sdk: ">=3.1.0-185.0.dev <4.0.0" | |||
sdk: ">=3.2.0-75.0.dev <4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However the String-based []
came later than this version. Looking at dart-lang/sdk@4efb33e1281, I believe you need 3.2.0-157.0.dev
instead
No description provided.