Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] LegacyNamespace extended attributes support on IDL interfaces (Resolves #283) #297

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

rutvik110
Copy link
Contributor

@rutvik110 rutvik110 commented Aug 30, 2024

[feat] LegacyNamespace extended attributes support on IDL interfaces (Resolves #283)


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@rutvik110 rutvik110 changed the title [feat] LegacyNamespace extended attributes support on IDL interfaces [feat] LegacyNamespace extended attributes support on IDL interfaces (Resolves #283) Aug 30, 2024
@rutvik110 rutvik110 requested a review from kevmoo August 31, 2024 06:08
web/CHANGELOG.md Outdated Show resolved Hide resolved
@kevmoo kevmoo requested a review from srujzs August 31, 2024 18:30
@kevmoo
Copy link
Member

kevmoo commented Aug 31, 2024

@srujzs should review, but this looks great. Thanks so much! 🙏

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

web_generator/CHANGELOG.md Show resolved Hide resolved
@rutvik110 rutvik110 force-pushed the feat_extended_attributes_support branch from 0cb30ff to a04e7e9 Compare September 4, 2024 02:40
@srujzs srujzs merged commit fb30192 into dart-lang:main Sep 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebAssembly related types are not properly annotated / namespaced.
3 participants