Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dictionary constructors to accept supertype members and create an empty object when there are no fields #197

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix dictionary constructors to accept supertype members and create an empty object when there are no fields #197

merged 3 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. Emit object literal constructors using parents' fields as well 

    Dictionaries can contain their supertypes' members as well and
therefore, these constructors should accept them.

https://webidl.spec.whatwg.org/#idl-dictionaries
    @srujzs
    srujzs committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5c4fb25 View commit details
    Browse the repository at this point in the history

  2. Generate constructors for dictionaries that have no members 

    These members should just initialize the representation field
as an empty object.
    @srujzs
    srujzs committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7b149f4 View commit details
    Browse the repository at this point in the history

  3. Bump to 0.6.0-wip and add changelog entry

    @srujzs
    srujzs committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    12b4997 View commit details
    Browse the repository at this point in the history