Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the tool/bindings_generator dart+node script into the top-level bindings_generator/ directory #123

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Dec 7, 2023

  • move the tool/bindings_generator dart+node script into the top-level bindings_generator/ directory
  • update the docs on regenerating the bindings

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo
Copy link
Member

kevmoo commented Dec 7, 2023

...uh...I guess?

@devoncarew
Copy link
Member Author

Well, this refactor isn't critical, but I think it does help to separate out the outer tool (tool/update_bindings.dart) - that you run from the cli - from the dart code that's compiled to JS and run as a node app (invoked from that initial tool). It helps clarify which dart files are compiled to JS and which aren't.

I have no issues closing the PR if you don't think its worth it; cc @kevmoo @srujzs.

@srujzs
Copy link
Contributor

srujzs commented Dec 15, 2023

I don't mind, it's nice to only keep update_bindings.dart in tools so you know what file to run easily.

final jsTypeSupertypesPath =
p.join(_bindingsGeneratorPath, 'js_type_supertypes.dart');
await File(jsTypeSupertypesPath).writeAsString(jsTypeSupertypesScript);
await _runProc(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the formatting done elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're just emitting code now that's already formatted :)

@devoncarew devoncarew merged commit e170bf2 into main Dec 15, 2023
11 checks passed
@devoncarew devoncarew deleted the bindings_generator branch December 15, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants