Skip to content

Commit

Permalink
Ignore unintended_html_in_doc_comment
Browse files Browse the repository at this point in the history
MDN docs includes some variants of html tags that this
rule disallows, like <table class="properties">, <th scope="row">,
and <br />. In order to make the CI pass, this is ignored for
now. Fixes cases unrelated to the MDN docs.
  • Loading branch information
srujzs committed Aug 12, 2024
1 parent e89fe49 commit 76a2a20
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 19 deletions.
33 changes: 18 additions & 15 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,21 @@ analyzer:

linter:
rules:
- avoid_bool_literals_in_conditional_expressions
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_returning_this
- avoid_unused_constructor_parameters
- cancel_subscriptions
- join_return_with_assignment
- literal_only_boolean_expressions
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_declarations
- prefer_final_locals
- unnecessary_await_in_return
- use_string_buffers
avoid_bool_literals_in_conditional_expressions: true
avoid_private_typedef_functions: true
avoid_redundant_argument_values: true
avoid_returning_this: true
avoid_unused_constructor_parameters: true
cancel_subscriptions: true
join_return_with_assignment: true
literal_only_boolean_expressions: true
no_adjacent_strings_in_list: true
no_runtimeType_toString: true
package_api_docs: true
prefer_const_declarations: true
prefer_final_locals: true
# MDN comments include HTML docs that trigger this lint. Reenable once
# that's resolved.
unintended_html_in_doc_comment: false
unnecessary_await_in_return: true
use_string_buffers: true
8 changes: 4 additions & 4 deletions tool/generator/webidl_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,10 @@ extension type Constant._(JSObject _) implements Member {
}

/// Grab bag to handle declarations in members:
/// * iterable<>
/// * async iterable<>
/// * maplike<>
/// * setlike<>
/// * iterable
/// * async iterable
/// * maplike
/// * setlike
extension type MemberDeclaration._(JSObject _) implements JSObject {
external String get type;
external IDLType get idlType;
Expand Down

0 comments on commit 76a2a20

Please sign in to comment.