Update CODEOWNERS for package:unified_analytics

[devoncarew]

• Update the CODEOWNERS file for package:unified_analytics

@andrewkolos, are you or @christopherfujino the best owner(s) for this package?

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[andrewkolos]

I consider this package to be un-owned. I (and @christopherfujino) have only contributed to it recently only to address critical flutter tool crashes. I don't wish to commit myself to properly owning this code given the current bandwidth of the Flutter Tools team.

If this change is mostly necessary just to make CI happy, I suppose I'm okay with my name being used here.

cc @christopherfujino @jtmcdole for thoughts

[devoncarew]

We do need this to be owned generally; its published in a dart publisher and core to several of our tools. When this was shipped initially Elias was the owner of record with the Flutter tools team providing backup ownership (ala b/267635605).

[devoncarew]

And the context, the CODEOWNERS file is not specifically intended to indicate ownership here as much as just cc specific people for PRs affecting portions of the repo's codebase.

[jtmcdole]

It sounds like this is a cross-tool package for shared logic. I believe we need more than one volunteer from an understaffed team to show real commitment. I'm not sure how Elias reported into the team, but he was the only one that said flutter tools would back it up.

What team can help share the burden?

[devoncarew]

I'm not sure how Elias reported into the team, but he was the only one that said flutter tools would back it up.

He was on the flutter tools team; and I do always get buy-in from a team's TL before publishing a package through the dart publishers - individual SWEs always move on.

It sounds like this is a cross-tool package for shared logic.

Yes, I believe that's correct. Used by flutter tools, the dart cli, devtools, and the analysis server? There is a periodic analytics sync, so perhaps ownership could be discussed there. The SLO for the published package is "This is not intended to be general purpose or consumed by the community. It is responsible for toggling analytics collection for related tooling on each developer's machine", so I think I'm mostly concerned with who would be on the hook for P0s.

[jtmcdole]

I checked in with the VM team and there are some threads I can track down as well. Thanks for keeping us honest!

[andrewkolos]

We do need this to be owned generally; its published in a dart publisher and core to several of our tools.

Agreed.

When this was shipped initially Elias was the owner of record with the Flutter tools team providing backup ownership (ala b/267635605).

I see—thanks for the link.

I believe we need more than one volunteer from an understaffed team to show real commitment.

Well said.

To be clear, I am happy to continue contributing this package (especially as it pertains to the flutter CLI tool). However, I feel being the owner could result in pains down the line that I would like to think about sooner rather than when it happens. Looking at the note of the last unified analytics sync meeting, it looks like ownership was discussed, but I don't see any conclusion written down. I assume there was none. I can attend the next sync and bring it up again then (in a few weeks).

He was on the flutter tools team; and I do always get buy-in from a team's TL before publishing a package through the dart publishers - individual SWEs always move on.

I agree with this practice. Still, the reason I'm hesitant here is how dramatically the Flutter tools team staffing situation changed since this was figured out. Consider the original two authors. Elias moved on, and Chris stepped up to lead eng prod efforts.

The tools team made a choice to be the owner of the package then, but it did not have much of a choice when it came to circumstances that have changed between then and now.

I think I'm mostly concerned with who would be on the hook for P0s.

I can take on this responsibility for now, and hopefully this can be addressed in the next analytics sync. Sorry for the noise.

[andrewkolos]

LGTM with caveats. See prior conversation.

[devoncarew]

Thanks! I'll land this as is - it'll be good to have a current name here. Please feel free to update as and when ownership discussions happen.

is how dramatically the Flutter tools team staffing situation changed since this was figured out

Yup, definitely agree that things have changed significantly since this was published.