Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure window.webkitConvertPointFromNodeToPage works if point is omitted #823

Closed
munificent opened this issue Dec 12, 2011 · 4 comments
Closed

Ensure window.webkitConvertPointFromNodeToPage works if point is omitted #823

munificent opened this issue Dec 12, 2011 · 4 comments
Assignees
@jacob314
Labels
closed-cannot-reproduce Closed as we were unable to reproduce the reported issue

Comments

@munificent
Copy link
Member

Marcin's feedback mentioned that the point is not optional here:

window.webkitConvertPointFromNodeToPage(bodyEl, new Point(0, 0));

According to the docs it is. Maybe it's not correctly handling a null point?
@DartBot
Copy link

DartBot commented Dec 13, 2011

This comment was originally written by drfibonacci@google.com

Added Triaged label.

@vsmenon
Copy link
Member

vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@jacob314
Copy link
Member

jacob314 commented May 2, 2012

This method is not marked as having optional arguments in the current dart:html.
I don't think there is any value in making the point argument optional and I'm guessing this was purely a bug in the original generated dart:html from december.

Added CannotReproduce label.

@jacob314
Copy link
Member

jacob314 commented May 2, 2012

This method is not marked as having optional arguments in the current dart:html.
I don't think there is any value in making the point argument optional and I'm guessing this was purely a bug in the original generated dart:html from december.

@munificent munificent added Type-Defect closed-cannot-reproduce Closed as we were unable to reproduce the reported issue labels May 2, 2012
copybara-service bot pushed a commit that referenced this issue Nov 28, 2022
@devoncarew
[deps] rev ffi, fixnum, http, markdown, protobuf, sse, test
32ae442 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ffi (https://github.com/dart-lang/ffi/compare/3ede231..17a8142):
  17a8142  2022-11-21  Daco Harkes  Add links to API reference and examples to README (#167)

fixnum (https://github.com/dart-lang/fixnum/compare/bca3816..62916f2):
  62916f2  2022-11-24  Lasse R.H. Nielsen  Split into separate libraries instead of using parts. (#97)
  14d4827  2022-11-23  Lasse R.H. Nielsen  Add `tryParse` methods. (#96)

http (https://github.com/dart-lang/http/compare/d56141d..047d6ed):
  047d6ed  2022-11-22  Brian Quinlan  Fixes a bug where requests made in different Clients would fail (#827)
  9dbbafb  2022-11-17  Brian Quinlan  Add tests for compressed responses (#823)

markdown (https://github.com/dart-lang/markdown/compare/37951d1..ee3f4e9):
  ee3f4e9  2022-11-24  Zhiguang Chen  Fix a blockquote issue (#496)
  c9048c0  2022-11-16  Zhiguang Chen  Optimise DelimiterSyntax (#492)

protobuf (https://github.com/dart-lang/protobuf/compare/ae90e53..c181573):
  c181573  2022-11-23  Kevin Moore  [api_benchmark] migrate to null-safety (#776)
  648deaf  2022-11-23  Kevin Moore  Standardize and fix lints (#775)
  bfa4c0d  2022-11-23  Kevin Moore  Fix `///` at the top of generated Dart files (#774)
  ed68426  2022-11-17  Devon Carew  Remove duplicate consts (#773)

sse (https://github.com/dart-lang/sse/compare/283568d..8d018dd):
  8d018dd  2022-11-23  Elliott Brooks (she/her)  Format markdown files (#68)
  2f6f151  2022-11-23  Elliott Brooks (she/her)  Add optional `debugKey` parameter to SSE client (#67)
  eaee6a8  2022-11-23  Elliott Brooks (she/her)  Use Fetch API in SSE Client (#66)

test (https://github.com/dart-lang/test/compare/7756833..b25dac9):
  b25dac99  2022-11-21  Kevin Moore  checks: finish async tests (#1793)
  3166163e  2022-11-18  Devon Carew  Update scorecards-analysis.yml (#1792)
  d930d5b0  2022-11-18  Nate Bosch  Add support for async soft checks (#1789)
  b1411a21  2022-11-18  Devon Carew  blast_repo fixes (#1788)
  a6aa04e0  2022-11-18  Jacob MacDonald  disable wasm tests for now as they are failing (#1791)
  8b5174c1  2022-11-17  Kevin Moore  Starting on async tests (#1787)

Change-Id: Ic361fce7753d08d43fc827f13cb1bfa1738cc16e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272343
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
closed-cannot-reproduce Closed as we were unable to reproduce the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@munificent @jacob314 @vsmenon @DartBot