Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wildcard Variables] Code Completion Support #56361

Closed
4 tasks done
Tracked by #55681
pq opened this issue Aug 1, 2024 · 1 comment
Closed
4 tasks done
Tracked by #55681

[Wildcard Variables] Code Completion Support #56361

pq opened this issue Aug 1, 2024 · 1 comment
Assignees
@pq
Labels
analyzer-completion Issues with the analysis server's code completion feature area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-wildcard-variables Implementation of the wildcard variables feature P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Aug 1, 2024 •
edited
Loading

Tests needed, work needed

  • Don’t want to suggest wildcards that can’t be referenced.
  • Test the situations for binding _ to make sure it still works. (Top level declarations, fields, etc)
  • Test import prefix named _ -> still nonbinding but can access extensions
  • @override works correctly with wildcards.
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-completion Issues with the analysis server's code completion feature feature-wildcard-variables Implementation of the wildcard variables feature labels Aug 1, 2024
@pq pq self-assigned this Aug 1, 2024
@pq pq mentioned this issue Aug 1, 2024
Open
46 tasks
copybara-service bot pushed a commit that referenced this issue Aug 1, 2024
@pq
[wildcards] completion tests
60c0933 
See: #56361

Change-Id: Ib69a64b17a890c6cec0e1bddfd25f6fa7834b1cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378620
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 2, 2024
@pq
[wildcards] completion suggestion support
6b16fab 
See: #56361

To follow, a bunch of tests to make sure `__`, `___`, etc are not incorrectly getting special cased.

Change-Id: I3d35a5344e09011460c074fdd43eccdac452a8ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 2, 2024
@pq
[wildcards] ensure bound __ underscores are suggested in completions
3b09a49 
See: #56361

Change-Id: Ia1b1a0fef17fb68f476d2ade96a0b5761152336b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 2, 2024
@pq
[wildcards] ensure overridden signatures preserve wildcards
2ffa9d1 
See: #56361

Change-Id: I0d37f8b3e034d123410151d3a82acdee5bc8fe9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member Author

pq commented Aug 2, 2024

Complete w/ 2ffa9d1.

@pq pq closed this as completed Aug 2, 2024
copybara-service bot pushed a commit that referenced this issue Aug 2, 2024
@pq
[wildcards] catch clause completion tests
4ec57e2 
See: #56361

Change-Id: I681e3b5ebfd2dcce3f377b8d45a492d44bf058a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378569
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 20, 2024
@pq
[wildcards] improve _ type param handling
6413386 
See: #56361

Change-Id: Ic3be09014afc095490d9332bd124843b5a65e1cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
analyzer-completion Issues with the analysis server's code completion feature area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-wildcard-variables Implementation of the wildcard variables feature P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq