[vm/ffi] Add example snippet to NativeCallable.listener
#53435
Labels
area-documentation
Prefer using 'type-documentation' and a specific area label.
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
library-ffi
Comments
dcharkes
added
area-vm
|
hey @dcharkes can you assign it yo me so i can fix it ! |
|
Sure. Feel free to submit a PR. Or even to just draft it in this thread. We usually ask someone from the language team for feedback on API/docs. |
copybara-service bot
pushed a commit
that referenced
this issue
Sep 22, 2023
This reverts commit 5354df6. Reason for revert: Broke debian-x64-main bot https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8769282695204884177/+/u/build/stdout Original change's description: > [ffi] NativeCallable.listener example. > > Add an example to the NativeCallable.listener documentation. > > Bug: #53435 > Change-Id: I4b664b14ca1dbc474913a9e191e38ca6f290350f > Fixes: #53435 > CoreLibraryReviewExempt: The FFI package is VM-only > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326580 > Reviewed-by: Daco Harkes <dacoharkes@google.com> > Commit-Queue: Liam Appelbe <liama@google.com> Bug: #53435 Change-Id: Id959500df51d0eaa9bd452d3d9d0a8b21191de1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327420 Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Liam Appelbe <liama@google.com> Commit-Queue: Alexander Aprelev <aam@google.com> Auto-Submit: Liam Appelbe <liama@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 24, 2023
But only reland the documentation. The test will need some more work. This is a reland of commit 5354df6 Original change's description: > [ffi] NativeCallable.listener example. > > Add an example to the NativeCallable.listener documentation. > > Bug: #53435 > Change-Id: I4b664b14ca1dbc474913a9e191e38ca6f290350f > Fixes: #53435 > CoreLibraryReviewExempt: The FFI package is VM-only > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326580 > Reviewed-by: Daco Harkes <dacoharkes@google.com> > Commit-Queue: Liam Appelbe <liama@google.com> Bug: #53435 Change-Id: Iafbf83ddcad47c7ae919f0730f5aa01a999eb083 CoreLibraryReviewExempt: The FFI package is VM-only Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327440 Reviewed-by: Lasse Nielsen <lrn@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Liam Appelbe <liama@google.com> Auto-Submit: Liam Appelbe <liama@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 28, 2023
The documentation changes already relanded. This is just relanding the example. Patchset 1 is a pure reland. Other patchsets are fixes. Original CL: https://dart-review.googlesource.com/c/sdk/+/326580 Change-Id: I04d24d63f08a351db7a6e43f331904274e28e2d5 Bug: #53435 TEST=samples/ffi/http/test/http_test.dart Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328681 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have users who want to start using the
NativeCallable.listener#37022 (comment).However, we don't have code samples illustrating its use in the API docs.
To aid users getting started with this new feature, the API docs should contain some sample code.
Some examples in API docs containing sample code:
@liamappelbe Could you take a stab at this?
The text was updated successfully, but these errors were encountered: