Failing co19 ffi tests

[mkustermann]

The following tests are failing:

FAILED: dartk-vm release_ia32 co19/LibTest/ffi/IntPtr/IntPtr_A01_t01
Expected: Pass
Actual: RuntimeError

--- Command "vm" (took 01.000386s):
DART_CONFIGURATION=ReleaseIA32 out/ReleaseIA32/dart --sound-null-safety --ignore-unrecognized-flags --packages=/usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/.packages /usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/LibTest/ffi/IntPtr/IntPtr_A01_t01.dart

exit code:
255

stderr:
Unhandled exception:
Expect.equals(expected: <-32768>, actual: <32768>) fails.
#0      _fail (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/Utils/expect.dart:20:5)
#1      Expect.equals (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/Utils/expect_common.dart:30:5)
#2      main (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/LibTest/ffi/IntPtr/IntPtr_A01_t01.dart:30:14)
#3      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283:19)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python tools/test.py -n dartk-strong-linux-release-ia32 co19/LibTest/ffi/IntPtr/IntPtr_A01_t01

                                                                                                                   
FAILED: dartk-vm release_ia32 co19/LibTest/ffi/Array/IntPtrArray_A01_t01                                                                                                                                           
Expected: Pass                                                                                                                                                                                                     
Actual: RuntimeError                                                                                                                                                                                               
                                                                                                                                                                                                                   
--- Command "vm" (took 02.000465s):                                                                                                                                                                                
DART_CONFIGURATION=ReleaseIA32 out/ReleaseIA32/dart --sound-null-safety --ignore-unrecognized-flags --packages=/usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/.packages /usr/local/google/home/kus
termann/repositories/sdk-gclient4/sdk/tests/co19/src/LibTest/ffi/Array/IntPtrArray_A01_t01.dart                                                                                                                    
                                                                                                                                                                                                                   
exit code:
255

stderr:
Unhandled exception:
Expect.equals(expected: <-32768>, actual: <32768>) fails.
#0      _fail (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/Utils/expect.dart:20:5)
#1      Expect.equals (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/Utils/expect_common.dart:30:5)
#2      main (file:///usr/local/google/home/kustermann/repositories/sdk-gclient4/sdk/tests/co19/src/LibTest/ffi/Array/IntPtrArray_A01_t01.dart:39:16)
#3      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283:19)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python tools/test.py -n dartk-strong-linux-release-ia32 co19/LibTest/ffi/Array/IntPtrArray_A01_t01

Assigned @dcharkes to triage whether the tests are wrong or the FFI implementation.

[dcharkes]

      if (sizeOf<IntPtr>() == 4) {
        array[i] = 32768;
        Expect.equals(-32768, array[i]);
        array[i] = -32768;
        Expect.equals(-32768, array[i]);
        array[i] = -32769;
        Expect.equals(32767, array[i]);
      } else {
        array[i] = 32768;
        Expect.equals(32768, array[i]);
        array[i] = -32769;
        Expect.equals(-32769, array[i]);
      }

The tests are wrong, the boundary should not be at +-2^15, but at +-2^31 for 4 byte/32 bit platforms.

[sgrekhov]

Fixed by dart-lang/co19@11238c2