Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler crash on package bots, in 1.19.0-dev.7.0 #27104

Closed
whesse opened this issue Aug 18, 2016 · 3 comments
Closed

Compiler crash on package bots, in 1.19.0-dev.7.0 #27104

whesse opened this issue Aug 18, 2016 · 3 comments
Assignees
@johnniwinther
Labels
dart2js-crash P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Milestone
1.19

Comments

@whesse
Copy link
Contributor

whesse commented Aug 18, 2016

The package bots have started failing on macos with a crash in the compiler, when 1.19.0-dev.7.0 landed:
https://build.chromium.org/p/client.dart.packages/builders/packages-mac-serialization.dart/builds/838

xcodebuild/ReleaseIA32/package_copy/serialization/build/test/serialization_test_common.dart:33:26:
Internal Error: The compiler crashed when compiling this element.
Node n1 = new Node("1"), n2 = new Node("2"), n3 = new Node("3");
^^
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

  • the name and version of your operating system,
  • the Dart SDK build number (1.19.0-dev.7.0), and
  • the entire message you see here (including the full stack trace
    below as well as the source location above).

The compiler crashed: The null object does not have a getter 'kind'.

NoSuchMethodError: method not found: 'kind'
Receiver: null
Arguments: []
#0 Object._noSuchMethod (dart:core-patch/object_patch.dart:44)
#1 Object.noSuchMethod (dart:core-patch/object_patch.dart:47)
#2 TypeCheckerVisitor.computeConstructorType (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:1619)
#3 TypeCheckerVisitor.visitNewExpression (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:1644)
#4 NewExpression.accept (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/tree/nodes.dart:774)
#5 TypeCheckerVisitor.analyze (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:441)
#6 TypeCheckerVisitor.analyzeNonVoid (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:415)
#7 TypeCheckerVisitor.visitVariableDefinitions (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:1775)
#8 VariableDefinitions.accept (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/tree/nodes.dart:1800)
#9 TypeCheckerTask.check.. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:68)
#10 CompilerTask.measure (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:63)
#11 TypeCheckerTask.check. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:62)
#12 CompilerDiagnosticReporter.withCurrentElement (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1549)
#13 TypeCheckerTask.check (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/typechecker.dart:61)
#14 _CompilerResolution.computeWorldImpact. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:2059)
#15 _HashVMBase&MapMixin&&_LinkedHashMapMixin.putIfAbsent (dart:collection-patch/compact_hash.dart:259)
#16 _CompilerResolution.computeWorldImpact (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:2040)
#17 Compiler.analyzeElement. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1038)
#18 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#19 Compiler.analyzeElement (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1025)
#20 Compiler.analyze. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1060)
#21 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#22 Compiler.analyze (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1042)
#23 ResolutionWorkItem.run (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/resolution.dart:52)
#24 Compiler.emptyQueue..... (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:946)
#25 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#26 Compiler.emptyQueue.... (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:945)
#27 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#28 Compiler.emptyQueue... (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:942)
#29 CompilerDiagnosticReporter.withCurrentElement (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:1549)
#30 Compiler.emptyQueue.. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:940)
#31 QueueFilter.processWorkItem (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/enqueue.dart:954)
#32 Enqueuer.forEach (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/enqueue.dart:645)
#33 Compiler.emptyQueue. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:939)
#34 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#35 Compiler.emptyQueue (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:938)
#36 Compiler.processQueue. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:975)
#37 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#38 Compiler.processQueue (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:952)
#39 Compiler.compileLoadedLibraries. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:815)
#40 CompilerTask.measureSubtask (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/common/tasks.dart:176)
#41 Compiler.compileLoadedLibraries (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:771)
#42 Compiler.runInternal. (file:///b/build/slave/dart-sdk-mac-dev/build/sdk/pkg/compiler/lib/src/compiler.dart:681)
#43 _RootZone.runUnary (dart:async/zone.dart:1404)
#44 _FutureListener.handleValue (dart:async/future_impl.dart:131)
#45 _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:637)
#46 _Future._propagateToListeners (dart:async/future_impl.dart:667)
#47 _Future._completeWithValue (dart:async/future_impl.dart:477)
#48 _Future._asyncComplete. (dart:async/future_impl.dart:528)
#49 _microtaskLoop (dart:async/schedule_microtask.dart:41)
#50 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#51 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#52 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)
@whesse whesse added web-dart2js P0 A serious issue requiring immediate resolution S1 high dart2js-crash type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Aug 18, 2016
@whesse whesse added this to the 1.19 milestone Aug 18, 2016
@whesse
Copy link
Contributor Author

whesse commented Aug 18, 2016 •
edited by sigmundch
Loading

The problem is reproducible on x64 linux, with the x64 1.19.0-dev.7.0 sdk in your path, with:

git clone git@github.com:google/serialization.dart.git
pub upgrade --no-packages-dir
dart2js --generate-code-with-compile-time-errors --test-mode test/serialization_test.dart

with the same stack trace. I will try binary search to find the CL causing this failure.

@whesse
Copy link
Contributor Author

whesse commented Aug 18, 2016

The issue is introduced by CL https://codereview.chromium.org/2244333003
@johnniwinther

@sigmundch
Copy link
Member

Johnni has a fix available at https://codereview.chromium.org/2250433007/

@whesse whesse mentioned this issue Aug 19, 2016
Closed
whesse pushed a commit that referenced this issue Aug 19, 2016
@johnniwinther @whesse
Type check field initializers in the correct context.
47f1415 
Closes #27104

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2250433007 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
dart2js-crash P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
1.19
Development

No branches or pull requests
3 participants
@sigmundch @whesse @johnniwinther