Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frog fails StringInterpolation8Test #2127

Closed
iposva-google opened this issue Mar 12, 2012 · 6 comments
Closed

frog fails StringInterpolation8Test #2127

iposva-google opened this issue Mar 12, 2012 · 6 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@iposva-google
Copy link
Contributor

It is now allowed to have constant expressions in string interpolation. See related bug: http://code.google.com/p/co19/issues/detail?id=100
@kasperl
Copy link

kasperl commented Mar 14, 2012

Added Accepted label.
Changed the title to: "frog and leg fails StringInterpolation8Test".

@kasperl
Copy link

kasperl commented Mar 14, 2012

This fails on frog because frog only allows constant strings (not bools or numbers) in constant interpolated strings. Fix on the way.

cc @lrhn.
Set owner to @kasperl.
Added Started label.

@kasperl
Copy link

kasperl commented Mar 24, 2012

Looks like this was fixed for leg. Updating summary.

Removed the owner.
Changed the title to: "frog fails StringInterpolation8Test".

@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, OldAreaFrog labels.

@anders-sandholm
Copy link
Contributor

Removed OldAreaFrog label.
Added FromAreaFrog label.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 1, 2023
@devoncarew
[deps] rev args, bazel_worker, dartdoc, http, leak_tracker, mockito, …
7b3305e 
…native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/f0f6cd2..a9543c0):
  a9543c0  2023-05-31  Devon Carew  switch to using package:dart_flutter_team_lints (#247)
  36407ea  2023-05-31  Devon Carew  adjust the validation of mandatory options (#246)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d9b389f..c14a268):
  c14a268  2023-05-31  Kevin Moore  Bump lints, regenerate proto file, fix script (#74)

dartdoc (https://github.com/dart-lang/dartdoc/compare/950898f..39fe1a8):
  39fe1a8a  2023-05-31  Parker Lougheed  Update highlight.js to 11.8.0 for Dart 3 syntax highlighting (#3416)
  4574e819  2023-05-30  Sam Rawlins  Convert kind to an enum (#3426)

http (https://github.com/dart-lang/http/compare/18a43a2..8834aec):
  8834aec  2023-05-31  Brian Quinlan  Update readme and prepare for a new release (#954)
  aca7f0e  2023-05-31  dependabot[bot]  Bump futureware-tech/simulator-action from 1 to 2 (#936)
  7a238a9  2023-05-31  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.4 (#952)
  4c0eb48  2023-05-30  Brian Quinlan  Prepare to publish cupertino_http 1.0.0 (#951)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/7f2cab3..cbbdeca):
  cbbdeca  2023-05-31  Polina Cherkasova  Improve getting retaining path. (#69)

mockito (https://github.com/dart-lang/mockito/compare/40fe2ca..924f65c):
  924f65c  2023-06-01  Ilya Yanok  Add support for records

native (https://github.com/dart-lang/native/compare/76bc55e..c851e69):
  c851e69  2023-06-01  dependabot[bot]  Bump nttld/setup-ndk (#57)
  0df0cad  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#58)
  c30faa2  2023-05-31  Daco Harkes  [c_compiler] test install_name_tool behavior (#56)
  45ef2e7  2023-05-31  Daco Harkes  [c_compiler] Support setting the install name of dylibs (#55)

protobuf (https://github.com/dart-lang/protobuf/compare/346a72d..da6953c):
  da6953c  2023-05-31  Kevin Moore  Update to latest lints and Dart SDK (#828)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c034352..3930557):
  3930557  2023-05-31  Kevin Moore  Bump lints, require Dart 3.0 (#89)

shelf (https://github.com/dart-lang/shelf/compare/a404b6a..ce379aa):
  ce379aa  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#363)

stack_trace (https://github.com/dart-lang/stack_trace/compare/86f7e30..8b2046e):
  8b2046e  2023-05-31  Devon Carew  blast_repo fixes (#134)

tools (https://github.com/dart-lang/tools/compare/d723a55..389925f):
  389925f  2023-06-01  Elias Yishak  Utility function added to check permissions on directory (#95)
  a436fee  2023-05-31  Elias Yishak  Asserts added to check all relevant GA4 limitations (#96)

vector_math (https://github.com/google/vector_math.dart/compare/cd87f57..a3aca09):
  a3aca09  2023-05-31  Lukas Klingsbo  fix: Revert negation change for Vector2 (#296)

webdev (https://github.com/dart-lang/webdev/compare/d442fa8..f565d7f):
  f565d7f1  2023-05-31  Anna Gringauze  Disable flaky test on windows (#2127)
  6eed300e  2023-05-31  Anna Gringauze  Cleanup expression evalaluation tests (#2125)

Change-Id: Ia568db23bbc923f764cdf323e249175b609d57ee
Tested: affected files are regenerated test goldens
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306903
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @kasperl @anders-sandholm @iposva-google