Dart Compiler bug- include #import('dart:typo');

[jwren]

What steps will reproduce the problem?

In a Dart file that is compilable and has no errors or warnings include an extra #import('dart:typo'); at the top of the file where "dart:typo" is not a valid dart library.

What is the expected output? What do you see instead?

An error or warning should be propagated instead of exceptions.

Also, in order to handle this use-case with the DeltaProcessor in the Dart Editor, if the LibrarySource class had an extra method to prompt if the URI is valid [before calling LibrarySource.getImportFor()] then the Dart Editor would be much more robust for this kind of typo. (For more information on this use-case in the Dart Editor, contact jwren@google.com.)

Please use labels and text to provide additional information.

Stack Trace:

!ENTRY com.google.dart.tools.core 4 4 2011-10-21 14:14:21.239
!MESSAGE Exception while building file:/Users/jwren/dart/HelloWorld/HelloWorld.dart
!STACK 0
java.lang.RuntimeException: Don't know how to expand dart URI: dart:jsona
    at com.google.dart.compiler.SystemLibraryManager.expandRelativeDartUri(SystemLibraryManager.java:133)
    at com.google.dart.compiler.UrlSource.<init>(UrlSource.java:51)
    at com.google.dart.compiler.UrlLibrarySource.<init>(UrlLibrarySource.java:17)
    at com.google.dart.compiler.DefaultCompilerConfiguration.getSystemLibraryFor(DefaultCompilerConfiguration.java:211)
    at com.google.dart.compiler.DartCompilerMainContext.getSystemLibraryFor(DartCompilerMainContext.java:185)
    at com.google.dart.compiler.DartCompiler$Compiler.updateLibraries(DartCompiler.java:353)
    at com.google.dart.compiler.DartCompiler$Compiler.updateAndResolve(DartCompiler.java:198)
    at com.google.dart.compiler.DartCompiler$Compiler.compile(DartCompiler.java:165)
    at com.google.dart.compiler.DartCompiler$Compiler.access$3(DartCompiler.java:162)
    at com.google.dart.compiler.DartCompiler.compileLib(DartCompiler.java:1110)
    at com.google.dart.compiler.DartCompiler.compileLib(DartCompiler.java:1086)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureCompileLib(DartCompilerUtilities.java:752)
    at com.google.dart.tools.core.internal.builder.DartBuilder.buildLibrary(DartBuilder.java:326)
    at com.google.dart.tools.core.internal.builder.DartBuilder.buildAllApplications(DartBuilder.java:253)
    at com.google.dart.tools.core.internal.builder.DartBuilder.build(DartBuilder.java:227)
    at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
    at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
    at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
    at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
    at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
    at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
    at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

[DartBot]

This comment was originally written by drfibonacci@google.com

---

Added Area-Editor, Triaged labels.

[jwren]

This is an issue with the compiler- not the editor.

---

Removed Area-Editor label.
Added Area-Compiler label.

[DartBot]

This comment was originally written by mmendez@google.com

---

Set owner to @jtmcdole.

[jtmcdole]

Fixed in r784. Second request under consideration.

---

Added Fixed label.

[jwren]

John-

Dartc is generating a NPE from a different location, "expanded" on line 52 of UrlSource is the source of the NPE instead of the previous trace:

java.lang.NullPointerException
    at com.google.dart.compiler.UrlSource.<init>(UrlSource.java:52)
    at com.google.dart.compiler.UrlLibrarySource.<init>(UrlLibrarySource.java:17)
    at com.google.dart.compiler.UrlLibrarySource.getImportFor(UrlLibrarySource.java:46)
    at com.google.dart.tools.core.internal.model.delta.DeltaProcessor.contentChanged_importDirectives(DeltaProcessor.java:618)
    at com.google.dart.tools.core.internal.model.delta.DeltaProcessor.contentChanged(DeltaProcessor.java:453)

---

Added Triaged label.

[jtmcdole]

NPE is a different bug from the assertion previously made. I will look into this.

[jtmcdole]

r1553

---

Added Fixed label.