All VM invocations crash in call to 'realpath' OS X 10.5.8

[DartBot]

This issue was originally filed by rice@google.com

---

In runtime/bin/file_macos.cc, the following code crashes on any VM invocation. Note that the allocated memory pointed to by resolved_path is never used on line 179. Changing 'NULL' to 'resolved_path' appears to fix the problem.

169 char* File::GetCanonicalPath(const char* pathname) {
170 char* abs_path = NULL;
171 if (pathname != NULL) {
172 // On some older MacOs versions the default behaviour of realpath allocating
173 // space for the resolved_path when a NULL is passed in does not seem to
174 // work, so we explicitly allocate space. The caller is responsible for
175 // freeing this space as in a regular realpath call.
176 char* resolved_path = reinterpret_cast<char*>(malloc(PATH_MAX + 1));
177 ASSERT(resolved_path != NULL);
178 do {
179 abs_path = realpath(pathname, NULL);
180 } while (abs_path == NULL && errno == EINTR);
181 ASSERT(abs_path == NULL || IsAbsolutePath(abs_path));
182 }
183 return abs_path;
184 }

[iposva-google]

Excellent timing. I am rewriting all of this code today.

---

Set owner to @iposva-google.
Added Accepted label.

[DartBot]

This comment was originally written by @mhausner

---

Is this still an issue? If so, does it need to be marked 'critical'?

[iposva-google]

Support for 10.5 is not a priority.

---

Removed Priority-Critical label.
Added Priority-Low label.

[iposva-google]

We will not support Mac OS X 10.5.

---

Added AssumedStale label.