Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wildcard Variables] support for avoid_types_as_parameter_names #5051

Closed
Tracked by #4969
pq opened this issue Aug 7, 2024 · 1 comment
Closed
Tracked by #4969

[Wildcard Variables] support for avoid_types_as_parameter_names #5051

pq opened this issue Aug 7, 2024 · 1 comment
Assignees
@pq
Labels
false-positive new-language-feature P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@pq
Copy link
Member

pq commented Aug 7, 2024

This is wrongly reporting:

class C<_> {
  var _;
  C.c(this._, _);
}
@pq pq added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) false-positive P2 A bug or feature request we're likely to work on new-language-feature labels Aug 7, 2024
@pq pq self-assigned this Aug 7, 2024
@pq pq mentioned this issue Aug 7, 2024
Open
@github-actions github-actions bot added the set-core Affects a rule in the core Dart rule set label Aug 7, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 8, 2024
@pq
[wildcards] support for avoid_types_as_parameter_names
a9c63ea 
Fixes: dart-lang/linter#5051

(Depends on https://dart-review.googlesource.com/c/sdk/+/379506.)


Change-Id: Ic94d24ed1e260bb2b068d298fa412c64cdae0f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379527
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member Author

pq commented Aug 8, 2024

Fixed w/ dart-lang/sdk@a9c63ea

@pq pq closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
false-positive new-language-feature P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq