Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wildcard Variables] support for avoid_final_parameters #5045

Closed
Tracked by #4969
pq opened this issue Aug 5, 2024 · 1 comment
Closed
Tracked by #4969

[Wildcard Variables] support for avoid_final_parameters #5045

pq opened this issue Aug 5, 2024 · 1 comment
Assignees
@pq
Labels
false-negative new-language-feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Aug 5, 2024

From the rule description:

Declaring parameters as final can lead to unnecessarily verbose code, especially when using the "parameter_assignments" rule.

My sense is we don't want to special case wildcards and flag final wildcards just like any other wildcard.

/cc @kallentu @bwilkerson @lrhn
@pq pq added type-enhancement A request for a change that isn't a bug false-positive P2 A bug or feature request we're likely to work on new-language-feature labels Aug 5, 2024
@pq pq self-assigned this Aug 5, 2024
@pq pq mentioned this issue Aug 5, 2024
Open
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 6, 2024
@pq
[wildcards] tests for avoid_final_parameters
964017a 
Fixes: dart-lang/linter#5045

Change-Id: I1060cfa4cb8f90101d62d05ed03b71b3eaf05ef9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378579
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@pq
Copy link
Member Author

pq commented Aug 6, 2024

Tested w/ dart-lang/sdk@964017a

@pq pq closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
false-negative new-language-feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq