-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaClient stream response body using byte arrays #1007
Merged
brianquinlan
merged 11 commits into
dart-lang:master
from
alex-james-dev:java-http-stream-response-body-with-byte-arrays
Aug 24, 2023
Merged
JavaClient stream response body using byte arrays #1007
brianquinlan
merged 11 commits into
dart-lang:master
from
alex-james-dev:java-http-stream-response-body-with-byte-arrays
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-james-dev
commented
Aug 22, 2023
alex-james-dev
commented
Aug 22, 2023
alex-james-dev
changed the title
Make JavaClient stream response body using byte arrays
JavaClient stream response body using byte arrays
Aug 22, 2023
I renamed the PR title to be <= 50 characters 😄 |
I've done a bit of refactoring to try to clean the code up a bit:
The PR is now ready for review! 🎉 Thank you! |
brianquinlan
approved these changes
Aug 24, 2023
alex-james-dev
deleted the
java-http-stream-response-body-with-byte-arrays
branch
August 24, 2023 17:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
JavaClient
streams the HTTP response body one byte at a time; this is slow. MakeJavaClient
stream the HTTP response body using byte arrays; this is faster. Each byte array can contain up to 4096 bytes.If none of the HTTP response body bytes are available without blocking, let the worker isolate's event loop run.
Generate bindings for
java.io.BufferedInputStream
usingjnigen
.Create a
BufferedInputStream
from the HTTP response bodyInputStream
to improve performance.Context
This is a PR for the
java_http
GSoC '23 project 🌞.Relevant tracking issue: #957.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.