Update lints to latest, etc (#1048)

Updated min SDK on http_client_conformance_tests Bumped pkg:http version on some examples
dart-lang · Nov 22, 2023 · 9fb4cfa · 9fb4cfa
1 parent 5e84d9f
commit 9fb4cfa
Show file tree

Hide file tree

Showing 14 changed files with 46 additions and 77 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -14,15 +14,10 @@ linter:
   - avoid_returning_this
   - avoid_unused_constructor_parameters
   - cascade_invocations
-  - comment_references
   - join_return_with_assignment
   - missing_whitespace_between_adjacent_strings
   - no_adjacent_strings_in_list
   - no_runtimeType_toString
-  - prefer_const_constructors
   - prefer_const_declarations
   - prefer_expression_function_bodies
-  - prefer_relative_imports
-  - test_types_in_equals
   - use_string_buffers
-  - use_super_parameters
diff --git a/pkgs/cronet_http/CHANGELOG.md b/pkgs/cronet_http/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 0.4.3-wip
+
 ## 0.4.2
 
 * Require `package:jni >= 0.7.2` to remove a potential buffer overflow.

diff --git a/pkgs/cronet_http/example/pubspec.yaml b/pkgs/cronet_http/example/pubspec.yaml
@@ -4,7 +4,7 @@ description: Demonstrates how to use the cronet_http plugin.
 publish_to: 'none'
 
 environment:
-  sdk: "^3.0.0"
+  sdk: ^3.0.0
 
 dependencies:
   cached_network_image: ^3.2.3
@@ -13,10 +13,10 @@ dependencies:
   cupertino_icons: ^1.0.2
   flutter:
     sdk: flutter
-  http: ^0.13.5
+  http: ^1.0.0
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   flutter_test:
     sdk: flutter
   http_client_conformance_tests:

diff --git a/pkgs/cronet_http/pubspec.yaml b/pkgs/cronet_http/pubspec.yaml
@@ -1,7 +1,7 @@
 name: cronet_http
 description: >
   An Android Flutter plugin that provides access to the Cronet HTTP client.
-version: 0.4.2
+version: 0.4.3-wip
 repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
 
 environment:
@@ -15,7 +15,7 @@ dependencies:
   jni: ^0.7.2
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   jnigen: ^0.7.0
   xml: ^6.1.0
   yaml_edit: ^2.0.3

diff --git a/pkgs/cupertino_http/CHANGELOG.md b/pkgs/cupertino_http/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 1.1.1-wip
+
 ## 1.1.0
 
 * Add websocket support to `cupertino_api`.

diff --git a/pkgs/cupertino_http/example/integration_test/client_test.dart b/pkgs/cupertino_http/example/integration_test/client_test.dart
@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:async';
 import 'dart:io';
 import 'dart:typed_data';
 
@@ -45,7 +46,7 @@ void testClient(Client client) {
       }
       final request = StreamedRequest('POST', uri);
       request.sink.add(data);
-      request.sink.close();
+      unawaited(request.sink.close());
       await client.send(request);
       expect(serverHash, sha1.convert(data).bytes);
     });

diff --git a/pkgs/cupertino_http/example/pubspec.yaml b/pkgs/cupertino_http/example/pubspec.yaml
@@ -16,12 +16,12 @@ dependencies:
   cupertino_icons: ^1.0.2
   flutter:
     sdk: flutter
-  http: ^0.13.5
+  http: ^1.0.0
 
 dev_dependencies:
   convert: ^3.1.1
   crypto: ^3.0.3
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   ffi: ^2.0.1
   flutter_test:
     sdk: flutter

diff --git a/pkgs/cupertino_http/pubspec.yaml b/pkgs/cupertino_http/pubspec.yaml
@@ -2,7 +2,7 @@ name: cupertino_http
 description: >
   A macOS/iOS Flutter plugin that provides access to the Foundation URL
   Loading System.
-version: 1.1.0
+version: 1.1.1-wip
 repository: https://github.com/dart-lang/http/tree/master/pkgs/cupertino_http
 
 environment:
@@ -17,7 +17,7 @@ dependencies:
   http: '>=0.13.4 <2.0.0'
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   ffigen: ^9.0.1
 
 flutter:

diff --git a/pkgs/flutter_http_example/pubspec.yaml b/pkgs/flutter_http_example/pubspec.yaml
@@ -17,11 +17,11 @@ dependencies:
   fetch_client: ^1.0.2
   flutter:
     sdk: flutter
-  http: ^0.13.5
+  http: ^1.0.0
   provider: ^6.0.5
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   flutter_test:
     sdk: flutter
   integration_test:

diff --git a/pkgs/http/CHANGELOG.md b/pkgs/http/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 1.1.2-wip
+
 ## 1.1.1
 
 * `BrowserClient` throws `ClientException` when the `'Content-Length'` header

diff --git a/pkgs/http/pubspec.yaml b/pkgs/http/pubspec.yaml
@@ -1,5 +1,5 @@
 name: http
-version: 1.1.1
+version: 1.1.2-wip
 description: A composable, multi-platform, Future-based API for HTTP requests.
 repository: https://github.com/dart-lang/http/tree/master/pkgs/http
 
@@ -13,7 +13,7 @@ dependencies:
   web: ^0.4.0
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   fake_async: ^1.2.0
   http_client_conformance_tests:
     path: ../http_client_conformance_tests/

diff --git a/pkgs/http_client_conformance_tests/pubspec.yaml b/pkgs/http_client_conformance_tests/pubspec.yaml
@@ -6,14 +6,14 @@ publish_to: none
 repository: https://github.com/dart-lang/http/tree/master/pkgs/http_client_conformance_tests
 
 environment:
-  sdk: '>=2.19.0 <3.0.0'
+  sdk: ^3.0.0
 
 dependencies:
   async: ^2.8.2
   dart_style: ^2.2.3
-  http: '>=0.13.4 <2.0.0'
+  http: ^1.0.0
   stream_channel: ^2.1.1
   test: ^1.21.2
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
diff --git a/pkgs/java_http/pubspec.yaml b/pkgs/java_http/pubspec.yaml
@@ -14,9 +14,8 @@ dependencies:
   path: ^1.8.0
 
 dev_dependencies:
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   http_client_conformance_tests:
     path: ../http_client_conformance_tests/
   jnigen: ^0.5.0
-  lints: ^2.0.0
   test: ^1.21.0