-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add environment input to support github deployment environments #131
Conversation
PR HealthPackage publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. License Headers ✔️Details
All source files should start with a license header. Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Before landing, please update the changelog + pubspec (to either 0.3.22-wip
or 0.3.22
); thanks!
if: ${{ github.event_name == 'push' }} | ||
|
||
# Require the github deployment environment if supplied. | ||
environment: ${{ inputs.environment }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a no-op if inputs.environment
is empty / not specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do assume so although I haven't found documentation on it. This is how the core dart-setup publish action works though.
Closes #130
Separates publish/validate into two different jobs. The publish job will use the supplied environment, which may require approvals to run the jobs if configured. See https://dart.dev/tools/pub/automated-publishing#hardening-security-with-github-deployment-environments.