Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate docs for enum static methods. #3697

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Commits on Mar 6, 2024

  1. Generate docs for enum static methods.

    Fixes dart-lang#3584
    
    The GeneratorFrontEnd code was really long, and I think that made it easy to omit things. I've refactored it to reuse more code. Also, the repeated code had bugs:
    
    * For extensions and extension types, we likely _over_-documented, because we didn't omit things that we're canonical.
    * For enums, we omitted static methods and static fields (dart-lang#3584).
    
    Also in this change:
    
    * Change some `clazz` and `eNum` parameter names to `class_` and `enum_`. More standard, and standard inside the analyzer.
    * Migrate methods_test.dart to use test_reflective_loader.
    * Add method tests for methods on classes, enums, mixins, extensions, and extension types.
    * In the shared testing code, add some code that prints out the in-memory files when a file cannot be read. Here's a snippet of what that looks like:
    
    ```none
    /temp/method_test/doc/
       ├─ index.html
       ├─ __404error.html
       ├─ search.html
       ├─ lib/
       │  ├─ lib-library.html
       │  ├─ lib-library-sidebar.html
       │  ├─ E-class.html
       │  ├─ E-enum-sidebar.html
       │  └─ E/
       │  │  ├─ values-constant.html
    ```
    srawlins committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    eb4394a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    cb06480 View commit details
    Browse the repository at this point in the history
  2. Back out inheritance change

    srawlins committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e188d5b View commit details
    Browse the repository at this point in the history