This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
update for null safety #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devoncarew
commented
Nov 7, 2020
devoncarew
commented
- update to support 2.12.0 and null safety
pq
reviewed
Nov 7, 2020
example/example.dart
Outdated
|
|
||
| Analytics getAnalytics() { | ||
| Analytics? getAnalytics() { |
There was a problem hiding this comment.
Seems like Analytics is sure to be non-null?
There was a problem hiding this comment.
Good point - done.
example/example.dart
Outdated
| } | ||
|
|
||
| return _analytics; | ||
| } | ||
|
|
||
| void _handleFoo() { | ||
| var analytics = getAnalytics(); | ||
| var analytics = getAnalytics()!; |
There was a problem hiding this comment.
In which case this bang can go away?
lib/src/usage_impl.dart
Outdated
| int drops; | ||
| int _lastReplenish; | ||
| late int drops; | ||
| late int _lastReplenish; | ||
|
|
||
| ThrottlingBucket(this.startingCount) { |
There was a problem hiding this comment.
Consider assigning drops in an initializer list. Then you can drop the late modifier?
There was a problem hiding this comment.
👍 - yup, this works
lib/src/usage_impl_io.dart
Outdated
|
|
||
| @override | ||
| void operator []=(String key, dynamic value) { | ||
| if (value == null && !_map.containsKey(key)) return; | ||
| if (_map[key] == value) return; | ||
| if (value == null && !_map!.containsKey(key)) return; |
There was a problem hiding this comment.
I'd be inclined to mark _map late so you can drop all of these bangs.
pubspec.yaml
Outdated
|
|
||
| dependencies: | ||
| path: ^1.4.0 | ||
| path: ^1.8.0-nullsafety.3 |
There was a problem hiding this comment.
Curious: why the .3 lower bound?
There was a problem hiding this comment.
This was just the latest available - I can drop to 1.8.0-nullsafety.
|
Thanks for the review! Updated with the latest - ptal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.